-
Notifications
You must be signed in to change notification settings - Fork 2
Surface Expr.reduce() in Python #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stumbled my way through this, would appreciate guidance on if there is a more idiomatic way to achieve the pyo3 logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new function, reduce, to the Python bindings in order to expose pyo3 logic for expression reduction.
- Added a new reduce function to the Expr struct in python/src/lib.rs.
- Updated the type hints and documentation in cql2.pyi to support the new function and improve type consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/src/lib.rs | Added the reduce function with de-pythonizing of input and error mapping. |
| cql2.pyi | Added a reduce method signature and updated add type annotation. |
Comments suppressed due to low confidence (2)
python/src/lib.rs:95
- [nitpick] If self.0 can be used without cloning, consider refactoring to avoid unnecessary cloning which might result in performance overhead.
.clone().reduce(value.as_ref())
cql2.pyi:137
- Using bare 'Expr' assumes that Expr is already defined; if it isn't, consider using a forward reference (e.g., "Expr") for compatibility with static type checkers.
def __add__(self, other: Expr) -> Expr:
alukach
commented
Mar 26, 2025
kylebarron
approved these changes
Mar 26, 2025
Co-authored-by: Kyle Barron <kyle@developmentseed.org>
gadomski
reviewed
Mar 27, 2025
gadomski
approved these changes
Mar 27, 2025
alukach
commented
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled my way through this, would appreciate guidance on if there is a more idiomatic way to achieve the pyo3 logic.