Add multi-platform builds#175
Add multi-platform builds#175stuartleeks merged 26 commits intodevcontainers:mainfrom natescherer:feature/multiple-architectures
Conversation
Synchronize from parent repo
|
Not sure why that test is failing? I've run build-local.sh multiple times and it doesn't show any changes, but the CI build test shows uncommitted changes to azdo-task/DevcontainersCi/dist/index.js. |
|
That's odd! I just grabbed the code and ran |
|
/test 74be82 |
|
🤖 pr-bot 🤖
(in response to this comment from @stuartleeks) |
|
/test 74be822 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3345799182 (in response to this comment from @stuartleeks) |
|
Thanks @natescherer - this looks really interesting. Based on the discussion in #150, it looks as though the It would be great to have a test that includes |
|
/test 07ef2d2 |
|
🤖 pr-bot 🤖 (in response to this comment from @stuartleeks) |
|
/test 07ef2d2 |
|
🤖 pr-bot 🤖
(in response to this comment from @stuartleeks) |
|
/test 003715a |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3387067256 (in response to this comment from @stuartleeks) |
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR! Didn't do a detailed review, but left a comment.
|
Looks like that latest merge from main meant build-local.sh needed ran again, which was blocking tests. |
|
/test 8e5e453 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3388696190 (in response to this comment from @stuartleeks) |
|
/test 1227e56 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3388841333 (in response to this comment from @stuartleeks) |
|
Oops, it looks like I forgot to revert my AzDO task version bump from when I was testing out the extension, sorry about that. This should get past that build bug. |
|
/test c2ec738 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3399443056 (in response to this comment from @stuartleeks) |
stuartleeks
left a comment
stuartleeks
left a comment
There was a problem hiding this comment.
looks good - thanks for the contribution!
|
Thanks for this! Really appreciate the multi-repo PRs and thought you put into it! |
4 participants
Hello!
This PR adds a platform input to both the GitHub Action and AzDO Task to allow mutli-platform builds. I've tested each successfully. I've also done my best to minimally modify the structure of the action/task.
Fixes part of #151.
Please let me know if you have any questions/changes!