Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add git-secrets docs [DET-5830] #2790

Merged
merged 2 commits into from
Jul 26, 2021
Merged

docs: add git-secrets docs [DET-5830] #2790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
510547c
Added git-secrets info to CONTRIBUTING.md
armandmcqueen Jul 26, 2021
e88f3b2
Referenced git-secrets in earlier section
armandmcqueen Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Referenced git-secrets in earlier section
  • Loading branch information
@armandmcqueen
armandmcqueen committed Jul 26, 2021
commit e88f3b21e9b7e0d8f0aae904127a30c52954f875
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ We welcome outside contributions. If you'd like to make a contribution, please:
We'd hate for you to duplicate effort is already in-flight.

1. Apply the linter with `make fmt` and test locally with `make test` before
submitting your code.

submitting your code. Make sure that your code doesn't accidentally include
cloud credentials. We recommend [using git-secrets to automatically prevent
this](#secrets).

1. The first time you submit code, you'll need to
[sign a CLA](https://determined.ai/cla/).

Expand Down