Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add git-secrets docs [DET-5830] #2790

Merged
merged 2 commits into from
Jul 26, 2021
Merged

docs: add git-secrets docs [DET-5830] #2790

merged 2 commits into from
Jul 26, 2021

Conversation

armandmcqueen
Copy link
Contributor

@armandmcqueen armandmcqueen commented Jul 26, 2021 •
edited by jira bot
Loading

Description

Test Plan

Manually tested GCP regex.

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2021
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for determined-ui canceled.

🔨 Explore the source changes: e88f3b2

🔍 Inspect the deploy log: https://app.netlify.com/sites/determined-ui/deploys/60ff2c2216b53d000850037a

@armandmcqueen armandmcqueen requested a review from mackrorysd July 26, 2021 20:56
@armandmcqueen armandmcqueen changed the title docs: add git-secrets docs docs: add git-secrets docs [DET-5830] Jul 26, 2021
mackrorysd
mackrorysd approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@mackrorysd mackrorysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should reference this, and probably the other pre-commit checks that we document under "Contributing Changes"?

@armandmcqueen armandmcqueen merged commit f10108f into master Jul 26, 2021
@dzhu dzhu deleted the add_git_secrets branch October 19, 2021 21:30
@dannysauer dannysauer modified the milestones: 0.0.102, 0.16.4 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackrorysd mackrorysd mackrorysd approved these changes

Assignees

@mackrorysd mackrorysd

Labels
cla-signed
Projects
None yet
Milestone
0.16.4
Development

Successfully merging this pull request may close these issues.
3 participants
@armandmcqueen @mackrorysd @dannysauer