Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added .pre-commit-hooks.yaml, fixes #8 and #9 #10

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Added .pre-commit-hooks.yaml, fixes #8 and #9 #10

merged 5 commits into from
Sep 18, 2023

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz
Copy link
Contributor Author

@mlucool Can this be merged?

@mlucool mlucool self-requested a review September 18, 2023 20:57
mlucool
mlucool requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@mlucool mlucool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Small change requested

src/main.rs Outdated Show resolved Hide resolved
@mlucool
Copy link
Member

mlucool commented Sep 18, 2023

Thanks again for the PR!

Please sign the CLA before we can merge your code.

mlucool
mlucool approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@mlucool mlucool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@mlucool mlucool merged commit 2be4ee8 into deshaw:main Sep 18, 2023
9 checks passed
@mlucool
Copy link
Member

mlucool commented Sep 18, 2023

Released as 1.0.2 on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlucool mlucool mlucool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@randolf-scholz @mlucool