Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove last empty line (conflict with end-of-file-fixer!) #8

Closed
randolf-scholz opened this issue Aug 18, 2023 · 0 comments · Fixed by #10
Closed

Do not remove last empty line (conflict with end-of-file-fixer!) #8

randolf-scholz opened this issue Aug 18, 2023 · 0 comments · Fixed by #10

Comments

@randolf-scholz
Copy link
Contributor

There is a conflict with the end-of-file-fixer pre-commit hook (https://pre-commit.com/hooks.html), which

ensures that a file is either empty, or ends with one newline.

But nbstripout-fast keeps removing the last empty line. (nbstripout doesn't)
randolf-scholz added a commit to randolf-scholz/nbstripout-fast that referenced this issue Aug 23, 2023
@randolf-scholz
fix deshaw#8: Do not remove last empty line.
04fc3b1
randolf-scholz added a commit to randolf-scholz/nbstripout-fast that referenced this issue Aug 23, 2023
@randolf-scholz
fix deshaw#8: Do not remove last empty line.
db16dbe
randolf-scholz added a commit to randolf-scholz/nbstripout-fast that referenced this issue Aug 23, 2023
@randolf-scholz
fix deshaw#8: Do not remove last empty line.
6f0db31
@randolf-scholz randolf-scholz mentioned this issue Aug 26, 2023
Merged
mlucool added a commit that referenced this issue Sep 18, 2023
@mlucool
Merge pull request #10 from randolf-scholz/main
2be4ee8 
Added .pre-commit-hooks.yaml, fixes #8 and #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added .pre-commit-hooks.yaml, fixes #8 and #9 randolf-scholz/nbstripout-fast
1 participant
@randolf-scholz