-
Notifications
You must be signed in to change notification settings - Fork 12
ci: Flashlight integration github action #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
behnam-deriv
wants to merge
13
commits into
deriv-com:master
Choose a base branch
from
behnam-deriv:flashlight-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fab90f3
chore: Add internet permission to Android manifest
behnam-deriv a23a17d
ci: Add performance check action
behnam-deriv ad58f5e
ci: Upgrade artifact upload action to v4
behnam-deriv 49b366e
ci: Adjust artifact upload path to match release APK
behnam-deriv 87cc37a
ci: Update Flashlight performance workflow to v4
behnam-deriv 821412f
ci: Update Flashlight performance workflow to trigger on all branches
behnam-deriv cdb150f
ci: combine Flashlight performance testing into main workflow
behnam-deriv 13210c0
ci: Update Flashlight CLI path configuration in workflow
behnam-deriv e266295
ci: Modify workflow dispatch and Maestro launch app configuration
behnam-deriv d2e549f
ci: Set 10 sec for Flashlight performance test duration
behnam-deriv 96a6953
ci: Add clearState to Maestro launch app test configuration
behnam-deriv 6ab63a0
Merge branch 'deriv-com:master' into flashlight-integration
behnam-deriv abc5fed
Merge branch 'deriv-com:master' into flashlight-integration
behnam-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
appId: com.example.chart_attempt | ||
--- | ||
- clearState | ||
- launchApp | ||
- assertVisible: Up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider pinning the Flashlight CLI installer version.
Pin the installer to a specific version to prevent unexpected CLI changes and ensure consistent, reproducible builds.
Suggested implementation:
If a different version should be used, update "v1.2.3" accordingly. Also, ensure that the pinned version is available and supported by the Flashlight CLI team.