-
Notifications
You must be signed in to change notification settings - Fork 12
ci: Flashlight integration github action #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: Flashlight integration github action #377
Conversation
Reviewer's GuideThis pull request integrates Flashlight performance testing by adding a new manually triggered job ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @behnam-deriv - I've reviewed your changes - here's some feedback:
- Consider running the Flashlight test job automatically on pull requests for earlier feedback.
Here's what I looked at during the review
- π‘ General issues: 1 issue found
- π’ Security: all looks good
- π’ Review instructions: all looks good
- π’ Testing: all looks good
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
- name: π List Downloaded Files | ||
run: ls -la apk/ | ||
|
||
- name: π§ Install Flashlight CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider pinning the Flashlight CLI installer version.
Pin the installer to a specific version to prevent unexpected CLI changes and ensure consistent, reproducible builds.
Suggested implementation:
curl https://get.flashlight.dev/v1.2.3 | bash
If a different version should be used, update "v1.2.3" accordingly. Also, ensure that the pinned version is available and supported by the Flashlight CLI team.
Clickup link: https://app.clickup.com/t/20696747/GRWT-3994
Fixes issue: #
This PR contains the following changes:
Developers Note (Optional)
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)
Summary by Sourcery
Add Flashlight integration GitHub Action for automated mobile app testing
New Features:
CI:
Deployment:
Chores: