-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add support for custom emoji #3184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@derailed Hello! May you check it please? |
70b94f2
to
82f3475
Compare
@imorte Thank you for this PR! I am not super keen on the current approach for these reasons:
What do you think? |
@derailed Thanks for the response! Yes, it all sounds reasonable. I will do it this way |
@imorte Thank you! |
4d69b66
to
65dc856
Compare
65dc856
to
9300146
Compare
@@ -80,7 +80,7 @@ type Prompt struct { | |||
|
|||
app *App | |||
noIcons bool | |||
icon rune | |||
icon string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple code points support
9300146
to
30418e4
Compare
@derailed Hi, what do you think about this PR? I can rebase and adapt it for the new version |
resolves #2624