Emoji replacements with k9s.json config strings #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great, is this only marked as failed bc the servers were not available for testing? if you re-trigger this is should work? |
derailed
added
enhancement
|
@CodyKlimkofski It looks like there are some conflicts and tests are no longer working. Could you take a peek? |
|
@derailed I can do it if the guy doesn't respond |
|
I think we should proceed with this in a separate PR. Would be quite a useful feature. |
|
see #3184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to resolve issue #2624. This is my first PR for any open source project so any feedback would be appreciated.