-
Notifications
You must be signed in to change notification settings - Fork 51
handle errors in dep, correctly catch missing url in version check #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle errors in dep, correctly catch missing url in version check #65
Conversation
replace console.error with throw to handle dep error failures in main try/catch to mark job as failed in one place
|
I have added very basic GH action to see if the workflow runs. You can see how it works here: https://github.com/piotrkwiecinski/action/actions/runs/4885561245/jobs/8719761093?pr=2 |
|
Is there any estimate on when/if this PR is expected to be merged? I am currently unable to deploy to my production server without it. |
|
Hi, whats the status here? This bug makes the action unusable. Dear Maintainers, can one of you merge the PR? |
|
There’s a conflict |
|
Hey @piotrkwiecinski, do you mind to rebase your PR and resolve the conflict? |
|
@Konafets I'll pick it up later today. |
f703f92 to
26be080
Compare
26be080 to
6ecfbf1
Compare
|
I reduced the change just to handle undefined url and left minimal test GH action. You can see it running here https://github.com/piotrkwiecinski/action/actions/runs/8193279635/job/22406665091 @antonmedv it should be ready to validade. Sorry for small spam. |
|
Thanks for taking care @piotrkwiecinski and @antonmedv! |
|
@piotrkwiecinski Did you already release/tag this fix? How should I use it? I have currently this configuration, and still failing: - name: Build and deploy
uses: deployphp/action@v1 |
|
To get around the issue I run |
replace console.error with throw to handle dep error failures in main try/catch to mark job as failed in one place
fixes: #63