Skip to content

Conversation

@piotrkwiecinski
Copy link
Contributor

replace console.error with throw to handle dep error failures in main try/catch to mark job as failed in one place

fixes: #63

replace console.error with throw to handle dep error failures
in main try/catch to mark job as failed in one place
@piotrkwiecinski
Copy link
Contributor Author

I have added very basic GH action to see if the workflow runs.

You can see how it works here: https://github.com/piotrkwiecinski/action/actions/runs/4885561245/jobs/8719761093?pr=2

@hashimaziz1
Copy link

hashimaziz1 commented Oct 19, 2023

Is there any estimate on when/if this PR is expected to be merged? I am currently unable to deploy to my production server without it.

@SimJoSt SimJoSt mentioned this pull request Jan 16, 2024
@Konafets
Copy link

Konafets commented Mar 5, 2024

Hi,

whats the status here? This bug makes the action unusable. Dear Maintainers, can one of you merge the PR?

@antonmedv
Copy link
Member

There’s a conflict

@Konafets
Copy link

Konafets commented Mar 7, 2024

Hey @piotrkwiecinski, do you mind to rebase your PR and resolve the conflict?

@piotrkwiecinski
Copy link
Contributor Author

@Konafets I'll pick it up later today.

@piotrkwiecinski
Copy link
Contributor Author

I reduced the change just to handle undefined url and left minimal test GH action. You can see it running here https://github.com/piotrkwiecinski/action/actions/runs/8193279635/job/22406665091

@antonmedv it should be ready to validade. Sorry for small spam.

@antonmedv antonmedv merged commit 6242095 into deployphp:master Mar 7, 2024
@Konafets
Copy link

Thanks for taking care @piotrkwiecinski and @antonmedv!

@ralphjsmit
Copy link

@piotrkwiecinski Did you already release/tag this fix? How should I use it?

I have currently this configuration, and still failing:

      - name: Build and deploy
        uses: deployphp/action@v1

@SimJoSt
Copy link
Contributor

SimJoSt commented Mar 25, 2024

To get around the issue I run composer install in the job and it will will use the local binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

curl -LO undefined

6 participants