Skip to content

Conversation

@Seb33300
Copy link

@Seb33300 Seb33300 commented Jun 30, 2023

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/undefined#description

A variable that has not been assigned a value is of type undefined.

Fix error in #63

Copy link
Contributor

@SimJoSt SimJoSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this doesn't fix the error in it entirety, I do prefer proper error handling. Thanks for the PR.

@antonmedv antonmedv closed this Jan 16, 2024
@Seb33300 Seb33300 deleted the patch-1 branch January 16, 2024 14:14
@SimJoSt
Copy link
Contributor

SimJoSt commented Jan 16, 2024

@antonmedv it would be great if you could provide a comment on why you closed this PR. It would help to create better contributions :)
Was the code quality or approach not up to snuff?
Is this approach superseded by another change? Maybe you want to focus on #65?

@antonmedv
Copy link
Member

Now sure what to say here.

@SimJoSt
Copy link
Contributor

SimJoSt commented Jan 16, 2024

@antonmedv I would love to give back a little, try to provide PRs, report bug reports, and testing.
If a PR is closed without a comment, I don't know what to make of it. Was it wrong? Broken? Unnecessary?
Any hint, why it was closed would help. It could be, that the reason is obvious, and I am just blind. I can't figure it out without some help :)

@Seb33300
Copy link
Author

I think I forgot the typeof

@SimJoSt
Copy link
Contributor

SimJoSt commented Jan 17, 2024

Ah, true. Could be.
Well, that would be an easy fix.

@antonmedv
Copy link
Member

It will be actually cool to refracture all this part more robust and include all the corner cases just type of could help but I’m not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants