Enable RSpec/DescribeClass #9730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
May 14, 2024
Comment on lines
7
to
9
| # rubocop:disable RSpec/DescribeClass | ||
| RSpec.describe "npm and yarn config" do | ||
| # rubocop:enable RSpec/DescribeClass |
There was a problem hiding this comment.
Suggested change
| # rubocop:disable RSpec/DescribeClass | |
| RSpec.describe "npm and yarn config" do | |
| # rubocop:enable RSpec/DescribeClass | |
| RSpec.describe "npm and yarn config" do # rubocop:disable RSpec/DescribeClass |
Feel entirely free to ignore this, but I always find this a bit more ergonomic to write, I don't think it's well documented that this is possible, but it disables the rule for the block
There was a problem hiding this comment.
That is so much better, thanks
jurre
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecdescribeclass