Skip to content

Commit

Permalink
Enable RSpec/DescribeClass (#9730)
Browse files Browse the repository at this point in the history
* Enable RSpec/DescribeClass

* move the comment
  • Loading branch information
robaiken authored May 15, 2024
1 parent c75943e commit e5a4933
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
7 changes: 0 additions & 7 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@ RSpec/ContainExactly:
RSpec/ContextWording:
Enabled: false

# Offense count: 2
# Configuration parameters: IgnoredMetadata.
RSpec/DescribeClass:
Exclude:
- 'elm/spec/dependabot/elm/update_checker/requirements_updater_spec.rb'
- 'npm_and_yarn/spec/npm_and_yarn_config_spec.rb'

# Offense count: 31
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
require "spec_helper"
require "dependabot/elm/update_checker/requirements_updater"

the_class = Dependabot::Elm::UpdateChecker::RequirementsUpdater
RSpec.describe the_class do
RSpec.describe Dependabot::Elm::UpdateChecker::RequirementsUpdater do
let(:updater) do
described_class.new(
requirements: requirements,
Expand Down
3 changes: 2 additions & 1 deletion npm_and_yarn/spec/npm_and_yarn_config_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

require "spec_helper"

RSpec.describe "npm and yarn config" do
# NOTE: This test does not have a corresponding class. It is testing the npm and yarn configuration.
RSpec.describe "npm and yarn config" do # rubocop:disable RSpec/DescribeClass
# NOTE: This comes from updater/config/.npmrc
it "contains a valid .npmrc config file" do
npm_result = `npm config list`
Expand Down

0 comments on commit e5a4933

Please sign in to comment.