Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout npm_and_yarn, Move some dockerfiles #6486

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Conversation

pavera
Copy link
Contributor

@pavera pavera commented Jan 19, 2023

This breaks out npm_and_yarn and also moves the previously broken out ecosystem's dockerfiles into their respective subdirs to avoid clutter at the top level.

@pavera pavera requested a review from a team as a code owner January 19, 2023 20:26
out.yml Outdated Show resolved Hide resolved
@jakecoffman
Copy link
Member

Hmmm can't tell what the issue is in the tests.

@pavera
Copy link
Contributor Author

pavera commented Jan 20, 2023

yeah, I'm digging to try to figure it out, I'll get it soon I'm sure.

@pavera pavera force-pushed the pavera/breakout-npm branch from be916f7 to 4bd7dc1 Compare January 20, 2023 17:57
@pavera pavera enabled auto-merge (squash) January 20, 2023 17:58
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pavera pavera merged commit 33f0172 into main Jan 20, 2023
@pavera pavera deleted the pavera/breakout-npm branch January 20, 2023 18:09
alcere pushed a commit that referenced this pull request Feb 20, 2023
* add npm_and_yarn dockerfile

* a little work towards npm

* Initial attempt at breaking out npm

This also moves the ecosystem specific dockerfiles into each ecosystem subdir to declutter

* remove accidentally commited file

* adding more ecosystem images (#6485)

* get helpers installed.

* bad order of ops here

Co-authored-by: Jake Coffman <jake@jakecoffman.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants