-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding more ecosystem images #6485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, cargo does have dependencies, I was a bit distracted while copy pasting this together. I'll go with it! |
jeffwidman
reviewed
Jan 19, 2023
Also added pipefail to the base image so that piped failures will fail to build the Docker image.
jakecoffman
force-pushed
the
jakecoffman/more-ecosystems
branch
from
January 19, 2023 20:59
f4e8183
to
0d221d9
Compare
pavera
approved these changes
Jan 20, 2023
pavera
pushed a commit
that referenced
this pull request
Jan 20, 2023
pavera
added a commit
that referenced
this pull request
Jan 20, 2023
* add npm_and_yarn dockerfile * a little work towards npm * Initial attempt at breaking out npm This also moves the ecosystem specific dockerfiles into each ecosystem subdir to declutter * remove accidentally commited file * adding more ecosystem images (#6485) * get helpers installed. * bad order of ops here Co-authored-by: Jake Coffman <jake@jakecoffman.com>
alcere
pushed a commit
that referenced
this pull request
Feb 20, 2023
* add npm_and_yarn dockerfile * a little work towards npm * Initial attempt at breaking out npm This also moves the ecosystem specific dockerfiles into each ecosystem subdir to declutter * remove accidentally commited file * adding more ecosystem images (#6485) * get helpers installed. * bad order of ops here Co-authored-by: Jake Coffman <jake@jakecoffman.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all of the ecosystem images that don't require additional dependencies.