ci-test: exit on error

bundler/lib/dependabot/bundler/update_checker/conflicting_dependency_resolver.rb

@@ -40,7 +40,7 @@ def conflicting_dependencies(dependency:, target_version:)
                 dependency_name: dependency.name,
                 target_version: target_version,
                 credentials: credentials,
-                lockfile_name: lockfile.name,
+                lockfile_name: lockfile.name
               }
             )
           end

bundler/lib/dependabot/bundler/update_checker/shared_bundler_helpers.rb

@@ -170,7 +170,7 @@ def inaccessible_git_dependencies
               args: {
                 dir: tmp_dir,
                 gemfile_name: gemfile.name,
-                credentials: credentials,
+                credentials: credentials
               }
             )
             git_specs.reject do |spec|
@@ -195,7 +195,7 @@ def jfrog_source
               args: {
                 dir: dir,
                 gemfile_name: gemfile.name,
-                credentials: credentials,
+                credentials: credentials
               }
             )
           end

bundler/script/ci-test

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -e
 
 bundle install
 bundle exec rubocop .

bundler/spec/dependabot/bundler/update_checker/latest_version_finder_spec.rb

@@ -197,18 +197,18 @@
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "dependency_source_type",
-                 args: anything
-               }).and_call_original
+            bundler_version: bundler_version,
+            function: "dependency_source_type",
+            args: anything
+          }).and_call_original
 
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "private_registry_versions",
-                 args: anything
-               }).
+            bundler_version: bundler_version,
+            function: "private_registry_versions",
+            args: anything
+          }).
           and_return(
             ["1.5.0", "1.9.0", "1.10.0.beta"]
           )
@@ -252,10 +252,10 @@
           allow(Dependabot::Bundler::NativeHelpers).
             to receive(:run_bundler_subprocess).
             with({
-                   bundler_version: bundler_version,
-                   function: "private_registry_versions",
-                   args: anything
-                 }).
+              bundler_version: bundler_version,
+              function: "private_registry_versions",
+              args: anything
+            }).
             and_raise(subprocess_error)
         end
 
@@ -285,10 +285,10 @@
           allow(Dependabot::Bundler::NativeHelpers).
             to receive(:run_bundler_subprocess).
             with({
-                   bundler_version: bundler_version,
-                   function: "private_registry_versions",
-                   args: anything
-                 }).
+              bundler_version: bundler_version,
+              function: "private_registry_versions",
+              args: anything
+            }).
             and_raise(subprocess_error)
         end
 
@@ -318,10 +318,10 @@
           allow(Dependabot::Bundler::NativeHelpers).
             to receive(:run_bundler_subprocess).
             with({
-                   bundler_version: bundler_version,
-                   function: "private_registry_versions",
-                   args: anything
-                 }).
+              bundler_version: bundler_version,
+              function: "private_registry_versions",
+              args: anything
+            }).
             and_raise(subprocess_error)
         end
 
@@ -351,10 +351,10 @@
           allow(Dependabot::Bundler::NativeHelpers).
             to receive(:run_bundler_subprocess).
             with({
-                   bundler_version: bundler_version,
-                   function: "private_registry_versions",
-                   args: anything
-                 }).
+              bundler_version: bundler_version,
+              function: "private_registry_versions",
+              args: anything
+            }).
             and_raise(subprocess_error)
         end
 
@@ -373,10 +373,10 @@
           allow(Dependabot::Bundler::NativeHelpers).
             to receive(:run_bundler_subprocess).
             with({
-                   bundler_version: bundler_version,
-                   function: "private_registry_versions",
-                   args: anything
-                 }).
+              bundler_version: bundler_version,
+              function: "private_registry_versions",
+              args: anything
+            }).
             and_return(
               []
             )
@@ -514,18 +514,18 @@
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "dependency_source_type",
-                 args: anything
-               }).and_call_original
+            bundler_version: bundler_version,
+            function: "dependency_source_type",
+            args: anything
+          }).and_call_original
 
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "private_registry_versions",
-                 args: anything
-               }).
+            bundler_version: bundler_version,
+            function: "private_registry_versions",
+            args: anything
+          }).
           and_return(
             ["1.5.0", "1.9.0", "1.10.0.beta"]
           )

bundler/spec/dependabot/bundler/update_checker/version_resolver_spec.rb

@@ -253,10 +253,10 @@
             allow(Dependabot::Bundler::NativeHelpers).
               to receive(:run_bundler_subprocess).
               with({
-                     bundler_version: PackageManagerHelper.bundler_version,
-                     function: "resolve_version",
-                     args: anything
-                   }).
+                bundler_version: PackageManagerHelper.bundler_version,
+                function: "resolve_version",
+                args: anything
+              }).
               and_return(
                 {
                   version: "3.0.2",
@@ -274,7 +274,6 @@
           context "and the dependency doesn't have a required Ruby version" do
             let(:rubygems_versions) do
               fixture(
-                "ruby",
                 "rubygems_responses",
                 "versions-public_suffix.json"
               ).gsub(/"ruby_version": .*,/, '"ruby_version": null,')

bundler/spec/dependabot/bundler/update_checker_spec.rb

@@ -156,18 +156,18 @@
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "dependency_source_type",
-                 args: anything
-               }).and_call_original
+            bundler_version: bundler_version,
+            function: "dependency_source_type",
+            args: anything
+          }).and_call_original
 
         allow(Dependabot::Bundler::NativeHelpers).
           to receive(:run_bundler_subprocess).
           with({
-                 bundler_version: bundler_version,
-                 function: "private_registry_versions",
-                 args: anything
-               }).
+            bundler_version: bundler_version,
+            function: "private_registry_versions",
+            args: anything
+          }).
           and_return(
             ["1.5.0", "1.9.0", "1.10.0.beta"]
           )

cargo/script/ci-test

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -e
 
 bundle install
 bundle exec rubocop .

common/script/ci-test

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -e
 
 bundle install
 bundle exec rubocop .