Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-test: exit on error #3660

Merged
merged 6 commits into from
May 6, 2021
Merged

ci-test: exit on error #3660

merged 6 commits into from
May 6, 2021

Conversation

thepwagner
Copy link
Contributor

@thepwagner thepwagner commented May 6, 2021

The most important change of the PR is to each ecosystem's script/ci-test scripts, introduced in #3426 . We want these shells to exit on the first non-zero status, not to return the status of their last command.

The previous version of these scripts masked problems:

  • Most commonly, the output of rubocop was ignored. I noticed this as style: use consistent indentation for first element #3649 changed rules and passed CI - but produced a diff when auto-applying locally.
  • In the python ecosystem, the pylint status was ignored. I fixed a whitespace issue
  • In the bundler ecosystem, the status of rspec is ignored - we'd removed some required fixtures and were looking for some fixtures in the wrong place.

Sorry for the meandering scope: it's fixing the CI script to detect problems, then trying to find a minimal resolution to problems that have crept in.

@thepwagner thepwagner self-assigned this May 6, 2021
@thepwagner
Copy link
Contributor Author

In this draft, I expect the go_modules build to fail: I think it had issues the automated fix couldn't resolve, and I wanted to demonstrate lint failures are build failures now.

@thepwagner thepwagner marked this pull request as ready for review May 6, 2021 19:54
@thepwagner thepwagner requested a review from a team as a code owner May 6, 2021 19:54
Copy link
Contributor

@mctofu mctofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@thepwagner thepwagner merged commit c639755 into main May 6, 2021
@thepwagner thepwagner deleted the lint-the-things branch May 6, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants