Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions CI: find Python undefined names #1375

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 10, 2019

Use GitHub Actions CI to find undefined names in Python code like the ones fixed in #1219.

Based on https://github.com/actions/starter-workflows/actions/new

@cclauss
Copy link
Contributor Author

cclauss commented Sep 10, 2019

These tests will not run until AFTER this PR is merged as discussed at https://help.github.com/en/articles/events-that-trigger-workflows#pull-request-events-for-forked-repositories

@greysteil
Copy link
Contributor

Nice! I'm not sure we want to add GItHub Actions at the same time as having CircleCI. Any thoughts @hmarr?

(If we want to add this to CircleCI we'd want to do so here.)

cclauss added a commit to cclauss/dependabot-core that referenced this pull request Sep 10, 2019
Like dependabot#1375 but without GitHub Actions.  Find syntax errors and undefined names in Python code like the ones fixed in dependabot#1219.
@hmarr
Copy link
Contributor

hmarr commented Sep 10, 2019

Yeah let's stick with CircleCI for now. Keen to move to Actions fully at some point, but that's a bigger job.

Looks like you've already opened #1376 (thanks for doing that so quickly!) - I assume that means this can be closed?

@cclauss cclauss closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants