Undefined names: Add missing imports #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[flake8](http://flake8.pycqa.org) testing of https://github.com/dependabot/dependabot-core on Python 3.7.1 $ __flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics__ ``` ./python/spec/fixtures/setup_files/with_open.py:10:9: F821 undefined name 'io' file3 = io.open("some_file", "r") ^ ./python/spec/fixtures/setup_files/with_open.py:16:17: F821 undefined name 'os' return open(os.path.join(os.path.dirname(__file__), fname)).read() ^ ./python/spec/fixtures/setup_files/with_open.py:16:30: F821 undefined name 'os' return open(os.path.join(os.path.dirname(__file__), fname)).read() ^ ./python/spec/fixtures/setup_files/with_parse_reqs.py:3:29: F821 undefined name 'parse_requirements' reqs = [str(r.req) for r in parse_requirements('requirements.txt', session=PipSession()) if r.req is not None] ^ ./python/spec/fixtures/setup_files/with_parse_reqs.py:3:76: F821 undefined name 'PipSession' reqs = [str(r.req) for r in parse_requirements('requirements.txt', session=PipSession()) if r.req is not None] ^ ./python/spec/fixtures/setup_files/with_pbr.py:4:14: F821 undefined name 'setuptools' packages=setuptools.find_packages(), ^ 6 F821 undefined name 'io' 6 ``` __E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety. * F821: undefined name `name` * F822: undefined name `name` in `__all__` * F823: local variable name referenced before assignment * E901: SyntaxError or IndentationError * E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
|
Thanks for this! |
cclauss
added a commit
to cclauss/dependabot-core
that referenced
this pull request
Sep 10, 2019
Use [GitHub Actions CI](https://github.com/features/actions) to find undefined names in Python code like the ones that were fixed in dependabot#1219 Based on https://github.com/actions/starter-workflows/actions/new
cclauss
added a commit
to cclauss/dependabot-core
that referenced
this pull request
Sep 10, 2019
Like dependabot#1375 but without GitHub Actions. Find syntax errors and undefined names in Python code like the ones fixed in dependabot#1219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 testing of https://github.com/dependabot/dependabot-core on Python 3.7.1
$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics
E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
namenamein__all__