Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements new endpoint behind feature flag #19445

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Implements new endpoint behind feature flag #19445

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
956d511
added new endpoint and implemented feature flag check, adds tests
tyler-spangler6 Nov 13, 2024
6e7db9e
corrected test failure and added integration test for new endpoint
tyler-spangler6 Nov 13, 2024
39600ac
refactored if statement based on code review
tyler-spangler6 Nov 18, 2024
deddb64
corrects linting errors
tyler-spangler6 Nov 18, 2024
78ff88d
mocked feature flag rather than enabling and disabling
tyler-spangler6 Nov 19, 2024
d3d9121
corrected linting
tyler-spangler6 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
corrected linting
  • Loading branch information
@tyler-spangler6
tyler-spangler6 committed Nov 19, 2024
commit d3d9121770d8e3a62c73f655c5067ba9135af77b
3 changes: 2 additions & 1 deletion spec/sidekiq/evss/disability_compensation_form/submit_form526_all_claim_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ def expect_non_retryable_error
before do
user = OpenStruct.new({ flipper_id: submission.user_uuid })
allow(Flipper).to receive(:enabled?).and_call_original
allow(Flipper).to receive(:enabled?).with(:disability_526_expanded_contention_classification, user).and_return(true)
allow(Flipper).to receive(:enabled?).with(:disability_526_expanded_contention_classification,
user).and_return(true)
end

it 'calls the expanded classification endpoint' do
Expand Down
Loading