Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements new endpoint behind feature flag #19445

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

tyler-spangler6
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES
  • This adds a new endpoint to the Virtual Regional Office client to perform contention classification using a new method
  • The call to the new end point called behind a feature flag that we plan to increase traffic to incrementally to test the response and response time

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Tests are written for the toggle on and off and is based on the user to plan for an incremental release
  • VCR cassettes are included for both the default classification and the method to test which endpoint is being called
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?
    • We plan to start by testing in staging and then doing a phased rollout to a small percentage of users

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to conditions-626-call-expanded-classifier/main/main November 13, 2024 19:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to conditions-626-call-expanded-classifier/main/main November 13, 2024 20:18 Inactive
@tyler-spangler6 tyler-spangler6 marked this pull request as ready for review November 13, 2024 20:53
@tyler-spangler6 tyler-spangler6 requested review from a team as code owners November 13, 2024 20:53
Copy link
Contributor

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a comment on an alternative implementation with pros and cons:

@rmtolmach rmtolmach requested a review from a team November 18, 2024 22:24
@rmtolmach rmtolmach added the Changes Requested The reviewer has requested changes from the PR author label Nov 18, 2024
nanotone
nanotone previously approved these changes Nov 19, 2024
Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 requested changes made. One last comment, but not blocking. Just keep in mind if you see any flakeyness.

@@ -14,6 +15,7 @@
Flipper.disable(:disability_compensation_lighthouse_claims_service_provider)
Flipper.disable(:disability_compensation_production_tester)
Flipper.disable(:disability_compensation_fail_submission)
Flipper.disable(:disability_526_expanded_contention_classification)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any test flakeyness shows up, these could be the culprit.

Copy link

Backend-review-group approval confirmed.

@tyler-spangler6 tyler-spangler6 merged commit 486286a into master Nov 20, 2024
32 checks passed
@tyler-spangler6 tyler-spangler6 deleted the conditions-626-call-expanded-classifier branch November 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested The reviewer has requested changes from the PR author require-backend-approval test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants