logging tests

lib/logging/monitor.rb

@@ -29,7 +29,7 @@ def track_request(error_level, message, metric, call_location: nil, **additional
           function:,
           file:,
           line:,
-          additional_context: context
+          additional_context:
         }
         Rails.logger.public_send(error_level, message.to_s, payload)
       else

modules/pensions/spec/lib/pensions/monitor_spec.rb

@@ -211,22 +211,50 @@
     end
 
     describe '#track_submission_exhaustion' do
-      it 'logs sidekiq job exhaustion' do
-        msg = { 'args' => [claim.id, current_user.uuid] }
+      context 'with a claim parameter' do
+        it 'logs sidekiq job exhaustion' do
+          notification = double(Pensions::NotificationEmail)
+          msg = { 'args' => [claim.id, current_user.uuid] }
+
+          log = 'Lighthouse::PensionBenefitIntakeJob submission to LH exhausted!'
+          payload = {
+            form_id: claim.form_id,
+            claim_id: claim.id,
+            confirmation_number: claim.confirmation_number,
+            message: msg
+          }
+
+          expect(Pensions::NotificationEmail).to receive(:new).with(claim).and_return notification
+          expect(notification).to receive(:deliver).with(:error)
+          expect(monitor).to receive(:log_silent_failure_avoided).with(payload, current_user.uuid, anything)
+
+          expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
+          expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
+
+          monitor.track_submission_exhaustion(msg, claim)
+        end
+      end
 
-        log = 'Lighthouse::PensionBenefitIntakeJob submission to LH exhausted!'
-        payload = {
-          form_id: claim.form_id,
-          claim_id: claim.id,
-          confirmation_number: claim.confirmation_number,
-          message: msg
-        }
+      context 'without a claim parameter' do
+        it 'logs sidekiq job exhaustion' do
+          msg = { 'args' => [claim.id, current_user.uuid] }
+
+          log = 'Lighthouse::PensionBenefitIntakeJob submission to LH exhausted!'
+          payload = {
+            form_id: nil,
+            claim_id: claim.id, # pulled from msg.args
+            confirmation_number: nil,
+            message: msg
+          }
+
+          expect(Pensions::NotificationEmail).not_to receive(:new)
+          expect(monitor).to receive(:log_silent_failure).with(payload, current_user.uuid, anything)
 
-        expect(monitor).to receive(:log_silent_failure).with(payload, current_user.uuid, anything)
-        expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
-        expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
+          expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
+          expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
 
-        monitor.track_submission_exhaustion(msg, claim)
+          monitor.track_submission_exhaustion(msg, nil)
+        end
       end
     end
 

spec/lib/burials/monitor_spec.rb

@@ -135,22 +135,51 @@
     end
 
     describe '#track_submission_exhaustion' do
-      it 'logs sidekiq job exhaustion' do
-        msg = { 'args' => [claim.id, current_user.uuid] }
+      context 'with a claim parameter' do
+        it 'logs sidekiq job exhaustion' do
+          notification = double(Burials::NotificationEmail)
 
-        log = 'Lighthouse::SubmitBenefitsIntakeClaim Burial 21P-530EZ submission to LH exhausted!'
-        payload = {
-          form_id: claim.form_id,
-          claim_id: claim.id,
-          confirmation_number: claim.confirmation_number,
-          message: msg
-        }
+          msg = { 'args' => [claim.id, current_user.uuid] }
+
+          log = 'Lighthouse::SubmitBenefitsIntakeClaim Burial 21P-530EZ submission to LH exhausted!'
+          payload = {
+            form_id: claim.form_id,
+            claim_id: claim.id,
+            confirmation_number: claim.confirmation_number,
+            message: msg
+          }
+
+          expect(Burials::NotificationEmail).to receive(:new).with(claim).and_return notification
+          expect(notification).to receive(:deliver).with(:error)
+          expect(monitor).to receive(:log_silent_failure_avoided).with(payload, current_user.uuid, anything)
+
+          expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
+          expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
+
+          monitor.track_submission_exhaustion(msg, claim)
+        end
+      end
+
+      context 'without a claim parameter' do
+        it 'logs sidekiq job exhaustion' do
+          msg = { 'args' => [claim.id, current_user.uuid] }
+
+          log = 'Lighthouse::SubmitBenefitsIntakeClaim Burial 21P-530EZ submission to LH exhausted!'
+          payload = {
+            form_id: nil,
+            claim_id: claim.id, # pulled from msg.args
+            confirmation_number: nil,
+            message: msg
+          }
+
+          expect(Burials::NotificationEmail).not_to receive(:new)
+          expect(monitor).to receive(:log_silent_failure).with(payload, current_user.uuid, anything)
 
-        expect(monitor).to receive(:log_silent_failure).with(payload, current_user.uuid, anything)
-        expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
-        expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
+          expect(StatsD).to receive(:increment).with("#{submission_stats_key}.exhausted")
+          expect(Rails.logger).to receive(:error).with(log, user_uuid: current_user.uuid, **payload)
 
-        monitor.track_submission_exhaustion(msg, claim)
+          monitor.track_submission_exhaustion(msg, nil)
+        end
       end
     end
   end

spec/lib/logging/monitor_spec.rb

@@ -26,11 +26,17 @@
       it 'logs a request with call location' do
         payload[:statsd] = 'api.monitor.404'
 
-        expect(StatsD).to receive(:increment).with('api.monitor.404',
-                                                   { tags: ['form_id:21P-50EZ'] })
+        expect(StatsD).to receive(:increment).with(metric, { tags: ['form_id:21P-50EZ'] })
         expect(Rails.logger).to receive(:error).with('404 Not Found!', payload)
 
-        monitor.track_request('error', '404 Not Found!', metric, additional_context, call_location:)
+        monitor.track_request('error', '404 Not Found!', metric, call_location:, **additional_context)
+      end
+
+      it 'logs an invalid log level' do
+        error_level = 'BAD_LEVEL'
+        expect(StatsD).to receive(:increment).with(metric, { tags: ['form_id:21P-50EZ'] })
+        expect(Rails.logger).to receive(:error).with("Invalid log error_level: #{error_level}")
+        monitor.track_request(error_level, 'TEST', metric, call_location:, **additional_context)
       end
     end
   end