Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBP 91426 Error email notification #19227

Merged
merged 22 commits into from
Nov 7, 2024

Conversation

wayne-weibel
Copy link
Contributor

@wayne-weibel wayne-weibel commented Nov 1, 2024

Summary

add email notification for silent failure of pension and burial claim - at submission and in LH

Related issue(s)

Trigger Pension and Burial Action Needed email notification
Trigger for downstream failure for Pension and Burial Action Needed email notification

https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/pull/3211
https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/pull/3212

needs these pr merged first:
#19301
#19302
#19288
#19323
#19326

Testing done

  • New code is covered by unit tests
  • triggered failure state in console, observed log of successful email job triggered

What areas of the site does it impact?

pension and burial

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@wayne-weibel wayne-weibel added burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions zero-silent-failures labels Nov 1, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 1, 2024 19:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 1, 2024 19:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 1, 2024 20:54 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 1, 2024 21:03 Inactive
Copy link

github-actions bot commented Nov 1, 2024

1 Warning
⚠️ This PR changes 369 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • app/sidekiq/benefits_intake_status_job.rb (+34/-0)

  • config/features.yml (+13/-1)

  • config/settings.yml (+12/-4)

  • lib/burials/monitor.rb (+7/-1)

  • lib/va_notify/notification_email/burial.rb (+0/-0)

  • lib/va_notify/notification_email/saved_claim.rb (+8/-7)

  • modules/pensions/lib/pensions/monitor.rb (+7/-1)

  • modules/pensions/lib/pensions/notification_email.rb (+0/-0)

  • modules/pensions/spec/lib/pensions/monitor_spec.rb (+49/-20)

  • spec/lib/burials/monitor_spec.rb (+49/-20)

  • spec/lib/va_notify/notification_email/saved_claim_spec.rb (+100/-36)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 1, 2024 21:41 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 4, 2024 17:10 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 6, 2024 19:59 Inactive
@wayne-weibel wayne-weibel marked this pull request as draft November 6, 2024 20:04
@wayne-weibel wayne-weibel marked this pull request as ready for review November 6, 2024 21:27
@wayne-weibel wayne-weibel marked this pull request as draft November 6, 2024 21:27
Copy link
Contributor

@balexandr balexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to pbp-91426-error-email-notification/main/main November 7, 2024 19:52 Inactive
@wayne-weibel wayne-weibel marked this pull request as ready for review November 7, 2024 20:27
@RachalCassity RachalCassity self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Backend-review-group approval confirmed.

@wayne-weibel wayne-weibel merged commit 577dfbd into master Nov 7, 2024
28 checks passed
@wayne-weibel wayne-weibel deleted the pbp-91426-error-email-notification branch November 7, 2024 21:18
pennja pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions require-backend-approval test-passing zero-silent-failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants