Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM-213/build lce interface and mockdata #19178

Merged
merged 20 commits into from
Oct 30, 2024
Merged

EDM-213/build lce interface and mockdata #19178

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6c3c6e3
Create lce client and config
jefftmarks Oct 24, 2024
59d6c8c
Create lce client methods
jefftmarks Oct 24, 2024
f79bd3e
Create lce controllers
jefftmarks Oct 25, 2024
d75df7e
Update gids redis to respond to lce client
jefftmarks Oct 25, 2024
92bce98
Create routes
jefftmarks Oct 25, 2024
bdb4189
Enable mocks
jefftmarks Oct 28, 2024
87693b7
Add gids response to lce client
jefftmarks Oct 28, 2024
cdd0108
Fix linting
jefftmarks Oct 28, 2024
f4a6e7a
Update gids redis spec
jefftmarks Oct 28, 2024
e5fcd73
LCE client spec
jefftmarks Oct 28, 2024
93c7e3a
Condense spec file
jefftmarks Oct 28, 2024
e9b8d79
Update codeowners
jefftmarks Oct 28, 2024
91b8acd
Fix linting
jefftmarks Oct 28, 2024
450e10c
Fix typo in spec test
jefftmarks Oct 28, 2024
5184bd5
Fix spec typo
jefftmarks Oct 29, 2024
b95bbbe
Fix spec typo
jefftmarks Oct 29, 2024
e424012
Fix spec
jefftmarks Oct 29, 2024
9aa8e40
Revert codeowners
jefftmarks Oct 29, 2024
86d7862
Merge branch 'master' into EDM-213/build-lce-interfaces-and-mockdata
jefftmarks Oct 30, 2024
9acd27b
Update services config and settings
jefftmarks Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in spec test
  • Loading branch information
@jefftmarks
jefftmarks committed Oct 28, 2024
commit 450e10ce6dd30f0b8c24b6c227a5b99cbb655358
2 changes: 1 addition & 1 deletion spec/models/gids_redis_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

context 'and the method belongs to `GI::SearchClient`' do
it 'delegates to `GI::SearchClient`' do
allows_any_instace_of(GI::SearchClient).to receive(get_lce_search_results_v1).and_return(gids_response)
allows_any_instance_of(GI::SearchClient).to receive(get_lce_search_results_v1).and_return(gids_response)

expect(subject.get_institution_search_results_v0(scrubbed_params)).to eq(gids_response.body)
end
Expand Down
Loading