Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM-213/build lce interface and mockdata #19178

Merged
merged 20 commits into from
Oct 30, 2024

Conversation

jefftmarks
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES/NO: No
  • (Summarize the changes that have been made to the platform): WEAMS Public data on licenses, certifications, and exams (LCE) is being integrated into the GIDS Comparison Tool. There is existing client that connects vets-website to gibct database through vets-api. Changes are to add new interfaces namespaced under LCE to handle requests for licenses, certifications, prep courses, and exams. In addition, as this integration is being rolled out, this PR enables betamocks to allow for devs to work locally and in staging
  • (If bug, how to reproduce) Not bug
  • (What is the solution, why is this the solution?) Add new routes, controllers, and client which inherit from and mirror existing GIDS interface. Maintain consistency of GIDS service while also separating LCE under its own namespace to enable shared behavior
  • (Which team do you work for, does your team own the maintenance of this component?) Education Data Migration (EDM), yes
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

GI Bill Comparison Tool (changes not in prod)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

1 Warning
⚠️ This PR changes 214 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • app/controllers/v1/gids/lce/certifications_controller.rb (+11/-0)

  • app/controllers/v1/gids/lce/exams_controller.rb (+11/-0)

  • app/controllers/v1/gids/lce/licenses_controller.rb (+11/-0)

  • app/controllers/v1/gids/lce/preps_controller.rb (+11/-0)

  • app/controllers/v1/gids/lce_controller.rb (+9/-0)

  • app/models/gids_redis.rb (+9/-0)

  • config/betamocks/services_config.yml (+21/-0)

  • config/routes.rb (+7/-0)

  • config/settings.yml (+2/-0)

  • lib/gi/configuration.rb (+4/-0)

  • lib/gi/lce/client.rb (+33/-0)

  • lib/gi/lce/configuration.rb (+10/-0)

  • spec/lib/gi/lce/client_spec.rb (+55/-0)

  • spec/models/gids_redis_spec.rb (+17/-3)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed in #19111

@@ -500,6 +500,8 @@ gids:
url: https://dev.va.gov/gids
open_timeout: 1
read_timeout: 1
lce:
use_mocks: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Backend-review-group approval confirmed.

@jefftmarks jefftmarks merged commit cf664de into master Oct 30, 2024
35 checks passed
@jefftmarks jefftmarks deleted the EDM-213/build-lce-interface-and-mockdata branch October 30, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants