Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbx-75526.2] add default state to form526 submissions #15801

Merged

Conversation

SamStuckey
Copy link
Contributor

@SamStuckey SamStuckey commented Mar 6, 2024

Summary

This is PR 2 of 3 to add state to our Form526Submission model. It follows the first PR here, per the documentation about migrations and default values here

  • *This work is behind a feature toggle (flipper): NO
  • add a default value of 'unprocessed' to our form526_submissions table in the aasm_state column

NOTE: this is not a wholeistic solution for end-to-end tracking. This work simply allows us a persistent, simple, queryable, and non-human-error-prone way to track submission state outside of the normal submission flow, ie remediation. There is a pretty good chance that this will be replaced in the next year or so with a global UUID for submissions (at least that's the current thinking).

Related issue(s)

Testing done

  • New code is covered by unit tests - No. tests will be added in the next PR when model logic is added. there is nothing to test.
  • Model instantiated and manipulated, nothing else to test

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@SamStuckey SamStuckey marked this pull request as ready for review March 6, 2024 16:08
@SamStuckey SamStuckey requested review from a team as code owners March 6, 2024 16:08
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@va-vfs-bot va-vfs-bot temporarily deployed to dbx/75526-add-default-state-to-form526submissions/main/main March 7, 2024 00:18 Inactive
@SamStuckey SamStuckey merged commit fd5bded into master Mar 7, 2024
20 checks passed
@SamStuckey SamStuckey deleted the dbx/75526-add-default-state-to-form526submissions branch March 7, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants