Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBX-75526.1] add aasm_state column to form526 subs #15736

Merged

Conversation

SamStuckey
Copy link
Contributor

@SamStuckey SamStuckey commented Feb 29, 2024

Top level documentation for this improvement is here

Summary

  • per the documentation, the Form 526 State machine is being broken into 3 migrations. This is the first which adds the requisite column to our form526 submission DB table.
  • A subsequent PR will add the default state value
  • A subsequent PR will add the model and implementation logic

Related issue(s)

Testing done

  • There is nothing to test, as this is bare bones, core rails functionality

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to dbx/75526-add-aasm_state-colum-to-form526-submissions/main/main February 29, 2024 15:49 Inactive
@SamStuckey SamStuckey force-pushed the dbx/75526-add-aasm_state-colum-to-form526-submissions branch from d442219 to 2b86d5c Compare February 29, 2024 21:15
@va-vfs-bot va-vfs-bot temporarily deployed to dbx/75526-add-aasm_state-colum-to-form526-submissions/main/main February 29, 2024 22:00 Inactive
tblackwe
tblackwe previously approved these changes Mar 1, 2024
@SamStuckey SamStuckey marked this pull request as ready for review March 1, 2024 15:12
@SamStuckey SamStuckey requested review from a team as code owners March 1, 2024 15:12
ryan-mcneil
ryan-mcneil previously approved these changes Mar 1, 2024
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SamStuckey SamStuckey dismissed stale reviews from ryan-mcneil and tblackwe via c475509 March 4, 2024 16:13
@SamStuckey SamStuckey force-pushed the dbx/75526-add-aasm_state-colum-to-form526-submissions branch from 2b86d5c to c475509 Compare March 4, 2024 16:13
@va-vfs-bot va-vfs-bot temporarily deployed to dbx/75526-add-aasm_state-colum-to-form526-submissions/main/main March 4, 2024 16:26 Inactive
@SamStuckey SamStuckey force-pushed the dbx/75526-add-aasm_state-colum-to-form526-submissions branch 2 times, most recently from efd1b59 to dee63a8 Compare March 5, 2024 13:26
@SamStuckey
Copy link
Contributor Author

Rebased to remove DB artifact, new review required

NB28VT
NB28VT previously approved these changes Mar 5, 2024
Copy link
Contributor

@NB28VT NB28VT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

freeheeling
freeheeling previously approved these changes Mar 5, 2024
Copy link
Contributor

@freeheeling freeheeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SamStuckey SamStuckey merged commit af1b654 into master Mar 5, 2024
19 checks passed
@SamStuckey SamStuckey deleted the dbx/75526-add-aasm_state-colum-to-form526-submissions branch March 5, 2024 23:25
rmtolmach added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants