Skip to content

Commit

Permalink
Install libyaml-dev in CI
Browse files Browse the repository at this point in the history
Needed to be able to install psych >=5.
Need to do it before setup-ruby runs as that runs `bundle install`.

Related to:
- ruby/psych#541
- ruby/setup-ruby#409
- actions/runner-images#6725

Yes, libyaml-dev will be added to GitHub runner images (this week they
say) but opening this PR just in case anyone encounters failing builds.
I don't think it hurts having this in the repo even after libyaml-dev
have been added to the images.

Added some blank lines to make the workflow easier to read.
  • Loading branch information
dentarg committed Dec 12, 2022
1 parent 4162502 commit 5e1e9c0
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,33 +28,46 @@ jobs:
rack: ${{ matrix.rack }}
puma: ${{ matrix.puma }}
steps:
- name: Install dependencies
run: |
sudo apt-get install --yes \
pandoc \
nodejs \
pkg-config \
libxml2-dev \
libxslt-dev \
libyaml-dev
- uses: actions/checkout@v3

- uses: ruby/setup-ruby@v1
continue-on-error: ${{ matrix.allow-failure || false }}
id: setup-ruby
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Install dependencies
run: sudo apt-get install -y pandoc nodejs pkg-config libxml2-dev libxslt-dev

- name: Run sinatra tests
continue-on-error: ${{ matrix.allow-failure || false }}
id: tests
run: bundle exec rake

- name: Run sinatra-contrib tests
continue-on-error: ${{ matrix.allow-failure || false }}
id: contrib-tests
working-directory: sinatra-contrib
run: |
bundle install --jobs=3 --retry=3
bundle exec rake
- name: Run rack-protection tests
continue-on-error: ${{ matrix.allow-failure || false }}
id: protection-tests
working-directory: rack-protection
run: |
bundle install --jobs=3 --retry=3
bundle exec rake
- uses: 8398a7/action-slack@v3
with:
status: ${{ job.status }}
Expand Down

0 comments on commit 5e1e9c0

Please sign in to comment.