-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bundled libyaml #541
Conversation
67b2219
to
36242ed
Compare
82b5283
to
8734035
Compare
.github/workflows/windows.yml
Outdated
- name: Run test | ||
run: rake | ||
k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k |
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops.
e430a38
to
5886bae
Compare
fc67210
to
aca703c
Compare
I only now realized there is already a PR for this on top of the original #535 - I would like to suggest not to merge this because there is a bug in the libyaml packaged in the currently used Ubuntu/Debian versions, and if I understand correctly merging this would render the fix (of not installing libyaml-dev) no longer working, see also rbenv/ruby-build#1950 (correct me if I'm wrong, maybe I'm also misunderstanding something about this or how psych and Ruby work together here) |
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
a595e99
to
3157783
Compare
3157783
to
fe57dfe
Compare
libyaml-dev is no longer bundled. ref: ruby/psych#541
libyaml-dev is no longer bundled. ref: ruby/psych#541
libyaml-dev is no longer bundled. ref: ruby/psych#541
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
Fixes #535