Skip to content

Comments

refactor(ini): remove IniMap#6515

Merged
kt3k merged 25 commits intodenoland:mainfrom
timreichen:ini-remove-IniMap
Apr 8, 2025
Merged

refactor(ini): remove IniMap#6515
kt3k merged 25 commits intodenoland:mainfrom
timreichen:ini-remove-IniMap

Conversation

@timreichen
Copy link
Contributor

Depends on #6514 and #6512

@github-actions github-actions bot added the ini label Mar 25, 2025
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (1853cde) to head (3a48484).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6515   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files         576      576           
  Lines       43199    43201    +2     
  Branches     6466     6466           
=======================================
+ Hits        41171    41173    +2     
  Misses       1989     1989           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen changed the title refactor(Ini): remove IniMap refactor(ini): remove IniMap Mar 25, 2025
@timreichen timreichen marked this pull request as ready for review April 7, 2025 16:35
@timreichen timreichen requested a review from kt3k as a code owner April 7, 2025 16:35
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k
Copy link
Member

kt3k commented Apr 8, 2025

More context: We used to expose IniMap as public API, which had capability of modifying the ini content while keeping the comments in the original. But we got several feedbacks that IniMap API is too complex and confusing and we decided to remove it during stabilization review in 2024.

@kt3k kt3k merged commit 92a059c into denoland:main Apr 8, 2025
18 checks passed
@timreichen timreichen deleted the ini-remove-IniMap branch April 8, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants