refactor(ini): simplify stringify()#6514
Merged
kt3k merged 10 commits intodenoland:mainfrom Apr 1, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6514 +/- ##
==========================================
- Coverage 95.29% 95.09% -0.21%
==========================================
Files 576 576
Lines 43315 43329 +14
Branches 6477 6460 -17
==========================================
- Hits 41279 41204 -75
- Misses 1995 2084 +89
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can you reduce unrelated changes (in @std/encoding)? |
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all stringify functionality from
IniMapinto thestringify()function.There is a load of unnecessary overhead generated the way
stringify()works inIniMap.Together with #6512
IniMapwill become obsolete and can be removed afterwards.