feat(http/unstable): headers module#4317
Merged
iuioiua merged 9 commits intodenoland:mainfrom Aug 6, 2024
Merged
Conversation
halvardssm
changed the title
iuioiua
changed the title
@std/http/headers
iuioiua
suggested changes
Aug 5, 2024
Contributor
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
Yoshiya and I would now like to have this addition.
Can you please remove HttpHeaderDeprecated, HttpHeaderObsoleted and HttpHeaderProvisional objects? What's now HttpHeaderPermanent seems to be the only object needed for now.
Can you please also add simple/minimal tests to ensure the plumbing works?
kt3k
changed the title
@std/http/headers@std/http/headers
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4317 +/- ##
==========================================
+ Coverage 96.38% 96.43% +0.04%
==========================================
Files 466 467 +1
Lines 37588 38097 +509
Branches 5542 5542
==========================================
+ Hits 36228 36737 +509
Misses 1318 1318
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@iuioiua Done! Let me know if there is anything else! |
iuioiua
changed the title
@std/http/headersheaders module
iuioiua
approved these changes
Aug 6, 2024
Contributor
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
LGTM! Thank you for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds IANA Headers as a follow-up from #4304