Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove std/node, it was merged into Deno itself #3206

Merged
merged 4 commits into from
Feb 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 0 additions & 4 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
# Use Unix line endings in all text files.
* text=auto eol=lf

# Tell github these are vendored files.
# Doesn't include them in the language statistics.
node/_tools/test/ linguist-vendored
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ fs/ @kt3k
http/ @kt3k
io/ @kt3k
log/ @kt3k
node/ @kt3k
path/ @kt3k
permissions/ @kt3k
semver/ @kt3k
Expand Down
41 changes: 1 addition & 40 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
shell: bash
# excludes tests, testdata, and generated sources from coverage report
run: |
deno coverage ./cov/ --lcov --exclude="test\\.(ts|js)|wasm\\.js|testdata|node/_tools|node/_module/cjs|node_modules" > cov.lcov
deno coverage ./cov/ --lcov --exclude="test\\.(ts|js)|wasm\\.js|testdata" > cov.lcov

- name: Upload coverage
uses: codecov/codecov-action@v3
Expand Down Expand Up @@ -69,42 +69,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.DENOBOT_PAT }}
run: ./_tools/release/03_release.ts

node:
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
deno: [canary]
os:
- ${{ github.repository_owner == 'denoland' && 'ubuntu-20.04-xl' || 'ubuntu-22.04' }}
- windows-2022
- macOS-latest

steps:
- name: Clone repository
uses: actions/checkout@v3
with:
submodules: true
persist-credentials: false

- name: Set up Deno
uses: denoland/setup-deno@v1
with:
deno-version: ${{ matrix.deno }}

- name: Type check node modules
shell: bash
run: deno task node:check-unstable-api

- name: Unit test node/
run: deno task node:unit

- name: Run Node tests canary
run: deno task node:test
env:
DENO_NODE_COMPAT_URL: file:///${{ github.workspace }}/

lint:
runs-on: ${{ github.repository_owner == 'denoland' && 'ubuntu-20.04-xl' || 'ubuntu-22.04' }}
steps:
Expand All @@ -125,9 +89,6 @@ jobs:
- name: Lint
run: deno lint

- name: Check circular dependencies
run: "deno task node:lint-circular-deps"

- name: Check License headers
run: deno task fmt:licence-headers --check

Expand Down
18 changes: 0 additions & 18 deletions .github/workflows/deploy.yml

This file was deleted.

9 changes: 2 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,22 +88,17 @@ Examples of bad titles:

Ensure there is a related issue and it is referenced in the PR text.

For contributions to the Node compatibility library please check the
[`std/node` contributing guide](./node/README.md)

_About CI checks_:

We currently have 9 checks on CI. Each PR should pass all of these checks to be
We currently have 7 checks on CI. Each PR should pass all of these checks to be
accepted.

- test with Deno canary on Windows
- test with Deno canary on Linux
- test with Deno canary on macOS
- test Node polyfill with Deno canary on Windows
- test Node polyfill with Deno canary on Linux
- test Node polyfill with Deno canary on macOS
- lint
- wasm crypto check
- wasm varint check
- CLA

_For maintainers_:
Expand Down
6 changes: 2 additions & 4 deletions _tools/check_assertions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ import { walk } from "../fs/walk.ts";

const ROOT = new URL("../", import.meta.url);
const EXTS = [".mjs", ".ts"];
const SKIP = [/(test|bench|node\/)/];
const SKIP = [/(test|bench)/];
const BAD_IMPORT = new URL("../testing/asserts.ts", import.meta.url);
const EXCEPTION = new URL("../node/assert.ts", import.meta.url);

async function getFilePaths(): Promise<string[]> {
const paths: string[] = [];
Expand All @@ -28,8 +27,7 @@ async function getFilePathsWithBadImports(): Promise<string[]> {
const paths = await getFilePaths();
const { modules } = await createGraph(paths);
return modules.filter(hasBadImports)
.map(({ specifier }: Module) => specifier)
.filter((path) => path !== EXCEPTION.href);
.map(({ specifier }: Module) => specifier);
}

const paths = await getFilePathsWithBadImports();
Expand Down
1 change: 0 additions & 1 deletion _tools/check_deprecation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { walk } from "../fs/walk.ts";
const EXTENSIONS = [".mjs", ".js", ".ts"];
const EXCLUDED_PATHS = [
".git",
"node",
"dotenv/testdata",
"fs/testdata",
"http/testdata",
Expand Down
1 change: 0 additions & 1 deletion _tools/check_doc_imports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const EXCLUDED_PATHS = [
".git",
".github",
"_tools",
"node",
];

const ROOT = new URL("../", import.meta.url);
Expand Down
4 changes: 0 additions & 4 deletions _tools/check_licence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,9 @@ import { globToRegExp } from "../path/glob.ts";

const EXTENSIONS = [".mjs", ".js", ".ts", ".rs"];
const EXCLUDED_DIRS = [
"**/node/_module",
"**/node/_tools/test",
"**/node/_tools/versions",
"**/dotenv/testdata",
"**/fs/testdata",
"**/http/testdata",
"**/node/testdata",
"**/crypto/_wasm/target",
"**/encoding/varint/_wasm/target",
];
Expand Down
6 changes: 0 additions & 6 deletions _tools/deploy.ts

This file was deleted.

2 changes: 1 addition & 1 deletion _tools/release/02_create_pr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function getPrBody() {
`- [ ] Releases.md is updated correctly\n` +
`- [ ] All the tests in this branch have been run against the CLI release being done` +
" ```shell" +
` ${TARGET} task test && ${TARGET} task node:unit && ${TARGET} task node:test` +
` ${TARGET} task test` +
" ```\n" +
`To make edits to this PR:\n` +
"```shell\n" +
Expand Down
24 changes: 0 additions & 24 deletions _util/download_file.ts

This file was deleted.

34 changes: 0 additions & 34 deletions _util/download_file_test.ts

This file was deleted.

6 changes: 3 additions & 3 deletions crypto/_wasm/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
`std/_crypto_wasm` is only for internal use, such as by `std/crypto` and
`std/node/crypto`. Its interface may not be stable between releases and it
should not be imported directly.
`std/_crypto_wasm` is only for internal use, such as by `std/crypto`. Its
interface may not be stable between releases and it should not be imported
directly.

## Overview

Expand Down
17 changes: 2 additions & 15 deletions deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
"cov",
"encoding/testdata/jsonc",
"encoding/front_matter/testdata",
"node/_tools/versions",
"node/_tools/test",
"node/integrationtest/yarn.js",
"wasi/testdata"
]
}
Expand All @@ -30,28 +27,18 @@
"encoding/testdata/jsonc",
"encoding/front_matter/testdata",
"cov",
"node/vendor",
"node/_module/node_modules/",
"node/_tools/versions",
"node/_tools/test",
"node/integrationtest/yarn.js",
"wasi/testdata"
]
}
},
"tasks": {
"test": "deno test --doc --unstable --allow-all --coverage=./cov --ignore=node/,_tools/testdata",
"test": "deno test --doc --unstable --allow-all --coverage=./cov --ignore=_tools/testdata",
"test:browser": "git grep --name-only \"This module is browser compatible.\" | grep -v deno.json | grep -v .github/workflows | xargs deno cache --check --reload --config browser-compat.tsconfig.json",
"fmt:licence-headers": "deno run --allow-read --allow-write ./_tools/check_licence.ts",
"lint:deprecations": "deno run --allow-read --allow-net ./_tools/check_deprecation.ts",
"lint:doc-imports": "deno run --allow-env --allow-read ./_tools/check_doc_imports.ts",
"lint:check-assertions": "deno run --allow-read --allow-net ./_tools/check_assertions.ts",
"lint": "deno lint && deno task node:lint-circular-deps && deno task fmt:licence-headers --check && deno task lint:deprecations && deno task lint:doc-imports && deno task lint:check-assertions",
"node:lint-circular-deps": "deno run --allow-read --allow-net=deno.land ./node/_tools/check_circular_deps.ts",
"node:unit": "deno test --unstable --allow-all --unsafely-ignore-certificate-errors node/ --ignore=node/_tools/test.ts,node/_tools/versions/",
"node:test": "deno test --unstable --allow-all node/_tools/test.ts",
"node:setup": "deno run --allow-read --allow-net --allow-write node/_tools/setup.ts",
"node:check-unstable-api": "deno check --unstable ./node/module_all.ts",
"lint": "deno lint && deno task fmt:licence-headers --check && deno task lint:deprecations && deno task lint:doc-imports && deno task lint:check-assertions",
"build:crypto": "deno task --cwd crypto/_wasm wasmbuild",
"build:varint": "deno task --cwd encoding/varint/_wasm wasmbuild",
"wasmbuild": "deno run --unstable -A https://deno.land/x/wasmbuild@0.10.3/main.ts --js-ext mjs --sync"
Expand Down
Loading