Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std/node, it was merged into Deno itself #3206

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Remove std/node, it was merged into Deno itself #3206

merged 4 commits into from
Feb 22, 2023

Conversation

ry
Copy link
Member

@ry ry commented Feb 17, 2023 •
edited
Loading

@ry ry requested review from kt3k and crowlKats as code owners February 17, 2023 14:20
@deno-deploy deno-deploy bot had a problem deploying to Preview February 17, 2023 14:20 Failure
kt3k
kt3k approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua
Copy link
Contributor

iuioiua commented Feb 19, 2023 •
edited
Loading

These LOC can be removed or modified:
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/.gitattributes#L4-L6
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/check_assertions.ts#L10
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/check_assertions.ts#L10-L33
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/check_deprecation.ts#L12
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/check_doc_imports.ts#L18
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/check_licence.ts#L7-L13
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/_tools/release/02_create_pr.ts#L42
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/crypto/_wasm/README.md?plain=1#L1-L3
https://github.com/denoland/deno_std/blob/4766e411f160da1e2f32877126eca3435c85f6cf/README.md?plain=1#L91-L104

These whole files can be deleted:

@kt3k
Copy link
Member

kt3k commented Feb 21, 2023

@iuioiua Thanks for your review! Addressed your comments

@kt3k kt3k requested a review from bartlomieju February 21, 2023 11:09
@iuioiua
Copy link
Contributor

iuioiua commented Feb 21, 2023

LGTM now!

@ry ry merged commit 1f96d9f into main Feb 22, 2023
@ry ry deleted the rm-node branch February 22, 2023 15:29
@Bubblyworld Bubblyworld mentioned this pull request Feb 24, 2023
Closed
@rmobis rmobis mentioned this pull request Feb 28, 2023
Closed
@kt3k kt3k mentioned this pull request Mar 7, 2023
Merged
@varHarrie varHarrie mentioned this pull request Mar 8, 2023
Open
tommy351 added a commit to tommy351/kosko that referenced this pull request Apr 3, 2023
@tommy351
build(deno): Remove std/node import
b8a7490 
denoland/std#3206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @iuioiua @kt3k