fix(node/net): setNoDelay and setKeepAlive no-ops #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
previously requested changes
Jan 17, 2022
There was a problem hiding this comment.
These should return the socket (i.e: this), see: https://nodejs.org/api/net.html#socketsetnodelaynodelay
These methods have no directly observable side effects and should therefore be safe to turn into no-ops. Doing so unblocks a number of third-party modules. Can be implemented once denoland/deno#13103 lands.
These are the internal handle methods, not the public |
My bad ! It was a quick review and I didn't check the full surrounding context ... |
bartlomieju
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods have no directly observable side effects and should
therefore be safe to turn into no-ops. Doing so unblocks a number
of third-party modules.
Can be implemented once denoland/deno#13103
lands.