Skip to content

Commit

Permalink
fix(node/net): setNoDelay and setKeepAlive no-ops (#1828)
Browse files Browse the repository at this point in the history
These methods have no directly observable side effects and should
therefore be safe to turn into no-ops. Doing so unblocks a number
of third-party modules.

Can be implemented once denoland/deno#13103
lands.
  • Loading branch information
bnoordhuis authored Jan 19, 2022
1 parent 7e2e6b9 commit fadcdc4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions node/internal_binding/tcp_wrap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ export class TCP extends ConnectionWrap {
* @return An error status code.
*/
setNoDelay(_noDelay: boolean): number {
notImplemented();
// TODO(bnoordhuis) https://github.com/denoland/deno/pull/13103
return 0;
}

/**
Expand All @@ -288,7 +289,8 @@ export class TCP extends ConnectionWrap {
* @return An error status code.
*/
setKeepAlive(_enable: boolean, _initialDelay: number): number {
notImplemented();
// TODO(bnoordhuis) https://github.com/denoland/deno/pull/13103
return 0;
}

/**
Expand Down

0 comments on commit fadcdc4

Please sign in to comment.