Skip to content

[BREAKING] Remove assertThrowsAsync from 'testing/' #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2021
Merged

[BREAKING] Remove assertThrowsAsync from 'testing/' #1646

merged 2 commits into from
Dec 13, 2021

Conversation

bartlomieju
Copy link
Member

Closes #1562

@bartlomieju bartlomieju requested a review from kt3k as a code owner November 28, 2021 16:04
@bartlomieju bartlomieju added this to the 1.17 milestone Nov 28, 2021
kt3k
kt3k approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit dcad206 into denoland:main Dec 13, 2021
@bartlomieju bartlomieju deleted the remove_assertThrowsAsync branch December 13, 2021 13:00
dpastoor added a commit to dpastoor/manual that referenced this pull request Jan 4, 2022
@dpastoor
remove assertThrowsAsync in favor of assertRejects
4f54068 
per denoland/std#1646 and denoland/std#1562 assertThrowsAsync has
been removed
@dpastoor dpastoor mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

Remove "assertThrowsAsync" in Deno v1.17
2 participants
@bartlomieju @kt3k