Remove "assertThrowsAsync" in Deno v1.17

[bartlomieju]

The "assertThrowsAsync" has been deprecated since August (over 3 months ago) and I think it's high time we remove it completely.

A good target would be Deno 1.17 (so probably 0.117.0 or 0.118.0 for deno_std).

[kitsonk]

The way it is being exported means that it does actually reflect in any IDE intellisense that it has been deprecated.

I was curious, because I was using it and wasn't seeing any warnings and I went and looked. The JSDoc block doesn't work that way... We would need to do something like:

/**
 * Executes a function which returns a promise, expecting it to throw or reject.
 * If it does not, then it throws.  An error class and a string that should be
 * included in the error message can also be asserted.
 *
 * @deprecated use `assertRejects` instead.
 */
export const assertThrowsAsync = assertRejects;

Also, its deprecation isn't reflected in the generated docs, so I don't think we should get rid of it until we actually properly inform people it is deprecated and what it is replaced with.

[kt3k]

Oh, I didn't realize this. Thank you for reporting this. I created a PR for the fix #1593

[kitsonk]

ooops, didn't mean to close it... sorry.

[bartlomieju]

Still I think we should remove it completely in Deno 1.17. #1583 was done abruptly as well and it seems @ry has no problem with removing APIs as std is still considered unstable.