Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs/mod.ts #1583

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Remove fs/mod.ts #1583

merged 2 commits into from
Nov 16, 2021

Conversation

ry
Copy link
Member

@ry ry commented Nov 15, 2021

Fixes #1539

@ry ry requested review from bartlomieju and kt3k as code owners November 15, 2021 14:40
@bartlomieju
Copy link
Member

This will break an enormous amount of code in the wild and doesn't solve the issue of requiring unstable at all. We should at least deprecate this module for a few release before removing completely.

@ry
Copy link
Member Author

ry commented Nov 15, 2021

We make breaking changes in std often. I would just remove this...

@LionC
Copy link
Contributor

LionC commented Nov 15, 2021

We make breaking changes in std often. I would just remove this...

@ry does that mean that you plan to cover even the more abstract FS related cases (e.g. walk) in the runtime API in the future? Or do you propose to straight up not cover them at all?

@bartlomieju
Copy link
Member

bartlomieju commented Nov 15, 2021

We make breaking changes in std often. I would just remove this...

I'm still not in favor of this change. This make it more cumbersome for users to import FS APIs (now you have to add 5 imports instead of one) without an obvious benefit. The root issues is still not resolved with this change.

@kt3k
Copy link
Member

kt3k commented Nov 15, 2021

How about only removing ./copy.ts from fs/mod.ts, which also resolves #1539 with less breaking changes.

@ry
Copy link
Member Author

ry commented Nov 15, 2021

@kt3k Ok I've made that change.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit d6673e2 into main Nov 16, 2021
@ry ry deleted the remove-fs-mod branch November 16, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std/fs/mod.ts depends on unstable APIs
4 participants