-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fs/mod.ts #1583
Remove fs/mod.ts #1583
Conversation
This will break an enormous amount of code in the wild and doesn't solve the issue of requiring unstable at all. We should at least deprecate this module for a few release before removing completely. |
We make breaking changes in std often. I would just remove this... |
@ry does that mean that you plan to cover even the more abstract FS related cases (e.g. |
I'm still not in favor of this change. This make it more cumbersome for users to import FS APIs (now you have to add 5 imports instead of one) without an obvious benefit. The root issues is still not resolved with this change. |
How about only removing |
@kt3k Ok I've made that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1539