Skip to content

canonicalize_port should use url::quirks::set_port #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

canonicalize_port should use url::quirks::set_port #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38b1034
Fix #53 - canonicalize_port should use url::quirks::set_port. Update …
valenting Jun 26, 2025
c03938d
Restore comment. Remove trim
valenting Jun 27, 2025
60fe7dd
Merge branch 'main' into main
lucacasonato Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/canonicalize_and_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,13 @@ pub fn canonicalize_port(
if let Some("") = protocol {
protocol = None;
}
let port = value
.parse::<u16>()
.map_err(|_| Error::Url(url::ParseError::InvalidPort))?;
// Note: this unwrap is safe, because the protocol was previously parsed to be
// valid.
let mut url =
url::Url::parse(&format!("{}://dummy.test", protocol.unwrap_or("dummy")))
.unwrap();
url.set_port(Some(port)).unwrap(); // TODO: dont unwrap, instead ParseError
url::quirks::set_port(&mut url, value)
.map_err(|_| Error::Url(url::ParseError::InvalidPort))?;
Ok(url::quirks::port(&url).to_string())
}

Expand Down
Loading