canonicalize_port should use url::quirks::set_port #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Update test data
|
|
Contributor
Author
|
@lucacasonato the CI is hanging for some reason. Could you retrigger it for me? |
src/lib.rs
Outdated
| } | ||
|
|
||
| let expected = expected.unwrap(); | ||
| let expected = expected.trim(); |
Contributor
Author
There was a problem hiding this comment.
Wasn't. Thanks for pointing it out.
Contributor
Author
|
@lucacasonato FYI, this crate is now backing our urlpattern implementation in Firefox 142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
https://urlpattern.spec.whatwg.org/commit-snapshots/696b4029d52e5854044bac6b72cdb198cb962ed0/#canonicalize-a-port
To do this we must use
url::quirks::set_portinstead of theurl::set_portmethod which takes a u16.Additionally this PR syncs the test data, except for a few which don't deserialize since they contained invalid UTF8.