Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dependency::with_new_resolver() #450

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

nayeemrmn
Copy link
Collaborator

This can be used in Document::maybe_with_new_resolver() to recompute resolutions without using Document::maybe_parsed_source.

We shouldn't be holding references to parsed/raw sources for non-open documents in memory. This would eliminate one usage.

@nayeemrmn nayeemrmn requested a review from dsherret April 18, 2024 01:21
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

src/graph.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit d179f32 into denoland:main Apr 18, 2024
4 checks passed
@nayeemrmn nayeemrmn deleted the dependency-with-new-resolver branch April 18, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants