Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lsp): cleanup document dependencies #23426

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Apr 17, 2024

  • Remove Document::maybe_module. This was only used for dependencies which are also stored in Document::dependencies.
  • Remove DocumentDependencies. Flatten Document::dependencies into Document::{dependencies,maybe_types_dependency}.
  • Optimize Document::maybe_with_new_resolver() using feat: add Dependency::with_new_resolver() deno_graph#450.
  • Fix some unnecessary cloning.

@nayeemrmn nayeemrmn changed the title chore(lsp): remove Document::maybe_module refactor(lsp): cleanup document dependencies Apr 17, 2024
@nayeemrmn nayeemrmn requested a review from dsherret April 17, 2024 21:53
@nayeemrmn nayeemrmn changed the title refactor(lsp): cleanup document dependencies perf(lsp): cleanup document dependencies Apr 19, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn enabled auto-merge (squash) April 19, 2024 00:44
@nayeemrmn nayeemrmn merged commit 8e77f09 into denoland:main Apr 19, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-documents-dead-code branch April 19, 2024 01:04
littledivy pushed a commit to littledivy/deno that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants