Skip to content

Conversation

@Tango992
Copy link
Member

Follow up to #31277

Copilot AI review requested due to automatic review settings November 14, 2025 06:32
Copilot finished reviewing on behalf of Tango992 November 14, 2025 06:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables four Node.js SQLite compatibility tests as a follow-up to PR #31277. The changes add the tests to the node compatibility configuration to ensure Deno's Node.js SQLite implementation is properly tested.

Key Changes:

  • Adds four SQLite-related test files to the node compatibility test suite

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bartlomieju
Copy link
Member

@Tango992 can you please sync up again once #31202 lands?

@Tango992
Copy link
Member Author

@Tango992 can you please sync up again once #31202 lands?

Sure 👍

@Tango992
Copy link
Member Author

@bartlomieju I've tested with changes from #31202 and the test results are the same

Signed-off-by: Daniel Osvaldo Rahmanto <daniel.rahmanto@gmail.com>
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

@Tango992 sounds good, have you gauged how much more work we need to get all the tests passing?

@Tango992
Copy link
Member Author

@Tango992 sounds good, have you gauged how much more work we need to get all the tests passing?

I'd say we would need a couple of weeks. Some of them are relatively easy like validating parameters, while some requires implementing new methods like db.function()

@Tango992 Tango992 merged commit 05395f3 into denoland:main Nov 17, 2025
19 checks passed
@Tango992 Tango992 deleted the enable-sqlite-tests branch November 17, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants