-
Notifications
You must be signed in to change notification settings - Fork 5.8k
chore(test): enable node sqlite tests #31285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables four Node.js SQLite compatibility tests as a follow-up to PR #31277. The changes add the tests to the node compatibility configuration to ensure Deno's Node.js SQLite implementation is properly tested.
Key Changes:
- Adds four SQLite-related test files to the node compatibility test suite
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@bartlomieju I've tested with changes from #31202 and the test results are the same |
Signed-off-by: Daniel Osvaldo Rahmanto <daniel.rahmanto@gmail.com>
bartlomieju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Tango992 sounds good, have you gauged how much more work we need to get all the tests passing? |
I'd say we would need a couple of weeks. Some of them are relatively easy like validating parameters, while some requires implementing new methods like |
Follow up to #31277