fix(ext/node): Add sqlite allow unknown named params option #31202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isAdrisal
commented
Nov 6, 2025
Contributor
Author
|
@bartlomieju I think this is ready to review if you have some time :) |
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Nov 17, 2025
…noland#31202) Adds [statement.setAllowUnknownNamedParameters(enabled)](https://nodejs.org/api/sqlite.html#statementsetallowunknownnamedparametersenabled) to `node:sqlite`. Closes denoland#31196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds statement.setAllowUnknownNamedParameters(enabled) to node:sqlite.
Closes #31196
This is my first commit to deno and I'm very new to rust so apologies in advance for any dumb mistakes!
I've mostly copied the implementation of
setAllowBareNamedParamsso hopefully it's mostly correct.