Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 refactor #12

Merged
merged 6 commits into from
Jul 25, 2018
Merged

v3 refactor #12

merged 6 commits into from
Jul 25, 2018

Conversation

msudgh
Copy link
Contributor

@msudgh msudgh commented Jul 24, 2018

I've made this PR to resolve #11 issue.

Changes:

  • Refactor core file and using object literals design pattern
  • Add typings file to support typescript language
  • Add contributors field to package.json

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "electron-is",
"version": "2.4.1",
"version": "3.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this change? I'll bump the version once I'll make the release :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sure!

Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit ffd2849 into delvedor:master Jul 25, 2018
@delvedor
Copy link
Owner

Landed in v3.0.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid using monkey-patch
2 participants