Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using monkey-patch #11

Closed
msudgh opened this issue Jul 24, 2018 · 3 comments · Fixed by #12
Closed

avoid using monkey-patch #11

msudgh opened this issue Jul 24, 2018 · 3 comments · Fixed by #12

Comments

@msudgh
Copy link
Contributor

msudgh commented Jul 24, 2018

For some reason, monkey-patch dynamic modifications aren't preferred. I suggest to read these pitfalls of monkey-patching and avoid using that in the library and also refactor the library.
@delvedor
Copy link
Owner

Pull request are welcome!

@msudgh
Copy link
Contributor Author

msudgh commented Jul 24, 2018

Great, As the library is less than 200 lines I'd like to use typescript, what do you think?

@delvedor
Copy link
Owner

You can definitely add the typings file, but I'd like the code to remain plain js.

@msudgh msudgh mentioned this issue Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3 refactor
2 participants
@delvedor @msudgh