feat: do not reveal sender's language in read receipts #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
approved these changes
Jul 26, 2024
link2xt
changed the title
|
@iequidoo do you have an idea what is wrong with jsonrpc ci? i did |
|
The issue is due to release of Rust 1.80: time-rs/time#693 |
|
I pushed this: c4efe59 |
while adapting strings for the recent change about read receipts, #5712 , it turns out in discussions eg. at deltachat/deltachat-android#3179 that untranslated english for the read receipts seem to be sufficient or even better: - do not reveal the sender's language - unexpected languages are confusing - even if you chat in english, you may get Chinese read receipts - many clients do not show the text anyways, iirc, eg. Outlook display the read receipts in context, and Delta Chat of course as well
r10s
force-pushed
the
r10s/simplify-read-receipt-text
branch
from
46d284b
to
a64d99c
Compare
|
thanks a lot! i rebased this pr, fingers crossed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while adapting strings for the recent change about read receipts, #5712 , it turns out in discussions eg. at deltachat/deltachat-android#3179 that untranslated english for the read receipts seem to be sufficient or even better:
multipart/reportuntranslated as well (sync, but also webxdc updates are practically english only)