Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt internal strings to changed "read receipt" behaviour #3179

Closed
r10s opened this issue Jul 24, 2024 · 1 comment · Fixed by #3180
Closed

adapt internal strings to changed "read receipt" behaviour #3179

r10s opened this issue Jul 24, 2024 · 1 comment · Fixed by #3180

Comments

@r10s
Copy link
Member

r10s commented Jul 24, 2024 •
edited
Loading

adapt stock strings to changes done at deltachat/deltachat-core-rust#5712 :

  • string DC_STR_READRCPT_MAILBODY (32) is deprecated, a warning is logged
  • string DC_STR_READRCPT_MAILBODY2 (192) is new

wondering if it isn't even better to leave the string in english, so only remove DC_STR_READRCPT_MAILBODY (32). there is not so much worth in translations, the string is usually not visible, and that way also no language setting is disclosed if the read receipt is sent unencrypted for whatever reason.

once this is settled for android, issues/pr for ios desktop need to be filed.
@iequidoo
Copy link
Contributor

wondering if it isn't even better to leave the string in english, so only remove DC_STR_READRCPT_MAILBODY2 (32). there is not so much worth in translations, the string is usually not visible, and that way also no language setting is disclosed if the read receipt is sent unencrypted for whatever reason.

+1, better in English and maybe even shorten to "This is a receipt notification." Moreover, read receipts are still unencrypted and there's no need to disclose the language setting even to contacts. And we don't know the contact's language setting, so we can't translate it properly.

r10s added a commit that referenced this issue Jul 26, 2024
@r10s
'read receipt' string is no longer needed
1bf20f2 
the stock string was removed,
and it is even considered to be better to leave the new one as english only,
see #3179
This was referenced Jul 26, 2024
Merged
Merged
r10s added a commit to deltachat/deltachat-core-rust that referenced this issue Jul 26, 2024
@r10s
do not reveal sender's language in read receipts
2e8aae0 
while adapting strings for the recent change about read receipts,
#5712 ,
it turns out in discussions eg. at deltachat/deltachat-android#3179
that untranslated english for the read receipts seem to be sufficient or even better:

- do not reveal the sender's language
- unexpected languages are confusing - even if you chat in english,
  you may get Chinese read receipts
- many clients do not show the text anyways,
  iirc, eg. Outlook display the read receipts in context,
  and Delta Chat of course as well
This was referenced Jul 26, 2024
Merged
Merged
r10s added a commit that referenced this issue Jul 26, 2024
@r10s
'read receipt' string is no longer needed
7aea2d0 
the stock string was removed,
and it is even considered to be better to leave the new one as english only,
see #3179
r10s added a commit to deltachat/deltachat-core-rust that referenced this issue Jul 26, 2024
@r10s
do not reveal sender's language in read receipts
52ebe02 
while adapting strings for the recent change about read receipts,
#5712 ,
it turns out in discussions eg. at deltachat/deltachat-android#3179
that untranslated english for the read receipts seem to be sufficient or even better:

- do not reveal the sender's language
- unexpected languages are confusing - even if you chat in english,
  you may get Chinese read receipts
- many clients do not show the text anyways,
  iirc, eg. Outlook display the read receipts in context,
  and Delta Chat of course as well
r10s added a commit to deltachat/deltachat-core-rust that referenced this issue Jul 26, 2024
@r10s
feat: do not reveal sender's language in read receipts (#5802)
03523ab 
while adapting strings for the recent change about read receipts,
#5712 , it turns
out in discussions eg. at
deltachat/deltachat-android#3179 that
untranslated english for the read receipts seem to be sufficient or even
better:

- do not reveal the sender's language
- unexpected languages are confusing - even if you chat in english, you
may get Chinese read receipts
- many clients do not show the text anyways, iirc, eg. Outlook display
the read receipts in context, and Delta Chat of course as well
- afaik, we're leaving comparable `multipart/report` untranslated as
well (sync, but also webxdc updates are practically english only)
- less code, fewer translations needed :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

read receipt stock string deltachat/deltachat-android
2 participants
@r10s @iequidoo